forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(qt): UI refresh (4/n, introduce distinct widgets for Dash-specific reporting in debug window, governance stats) #7118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kwvg
wants to merge
49
commits into
dashpay:develop
Choose a base branch
from
kwvg:info_refresh
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,144
−2,699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also `s/coinJoinEnabledChanged/showCoinJoinChanged/g` to establish a naming convention that will be used soon.
This should fix the misalignment of the `subFeeFromAmount` `QCheckBox` compared to the rest of the `QCheckBox`es Review with `git log -p -n1 --ignore-space-change --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Inheriting the whole structure is overkill just to use `tr` and `hash()` is used in hot loops so we should cache the value in the ctor. Also remove dead variable.
Review with `git log -p -n1 --ignore-space-change --color-moved=dimmed_zebra`.
This is closer to how we report details for transactions and more translation-friendly and easier to copy.
Visiting URLs could be dangerous, add a warning before we open a link in someone's browser.
Dash Governance Tools' budget generator is a much more visually friendly design and we can model our wizard after it.
The JSON and payload hex means little for the vast majority of users, what matters is the error messages, so we responsively validate contents and drop an extra panel in the process.
The visual language should match other coin-spending activities, also warn that that you don't get the fee back.
The proposal creation process can be interrupted for reasons beyond our control, since submitting the actual proposal is different from spending the collateral, it should have its own page. Right now this removes the old code but doesn't create a new layout, we will do that in the next commit.
This replaces the remaining pages of the proposal wizard that we removed in the last commit.
You cannot create a proposal without an adequate balance, it's a bad idea to allow any kind of proposal manipulation without being synced.
This is a more inexpensive operation since we aren't getting a diff set, we're getting the whole list repeatedly.
We are no longer using the wizard format so the name is a misnomer, the
logic is also relatively simplified (as now half of it is in
`qt/proposalresume.{cpp,h}`)
Applying our font causes drift to be introduced for some reason if baked into the layout but this doesn't seem to be an issue if done programmatically
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Collaborator
|
@kwvg would it be difficult to also add the age of the quorums in addition to their health? On testnet some of those quorums haven't formed for years if I'm not mistaken. Would be nice to know if quorums were "fresh" and when the next ones are expected to form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
Breaking Changes
None expected.
Checklist